search

mate-desktop / mate-themes

Official themes for the MATE desktop
https://mate-desktop.org
GNU Lesser General Public License v2.1
76 stars 45 forks source link

Theme disturbances with themes v3.22.20 #255

Closed Mno-hime closed 3 years ago

Mno-hime commented 5 years ago

I updated OpenIndiana 2019.04 (MATE 1.22) with marco 1.22.2 and mate-themes 3.22.20 and there are several disturbances in MATE shipped themes. Composition is on but it affects only the tooltip problem (see below).

Mno-hime commented 5 years ago

Updated to the latest updates from 1.22 stream, the problem is still present for me. Any idea what goes wrong here? What does the "template wrong" label mean?

rbuj commented 5 years ago 
$ LANG=C pkg info mate-themes
          Name: desktop/mate/mate-themes
       Summary: MATE Themes
      Category: System/Libraries
         State: Installed
     Publisher: openindiana.org
       Version: 3.22.19
        Branch: 2018.0.0.0
Packaging Date: Sat May  4 09:48:24 2019
          Size: 74.96 MB
          FMRI: pkg://openindiana.org/desktop/mate/mate-themes@3.22.19-2018.0.0.0:20190504T094824Z
   Project URL: http://www.mate-desktop.org
    Source URL: http://pub.mate-desktop.org/releases/themes/3.22/mate-themes-3.22.19.tar.xz

The tooltips are not displayed correctly ONLY in TraditionalOK and TraditionalGreen controls when the software compositor is enabled.

TraditionalOK

Captura de pantalla a 2019-09-20 11-03-07

Menta

Captura de pantalla a 2019-09-20 11-06-33

lukefromdc commented 5 years ago

I cannot duplicate what you have observed in BlackMATE on Debian Unstable. This looks a lot like what happened in some of the major GTK 3 version transitions before 3.20, but MATE 1.22 only builds with GTK 3.22 or later.

Check to ensure the theme assets (image files) got installed in the theme directories. In BlackMATE, missing image files could cause exactly what you are seeing. If you install themes to /usr/share/themes, the image files for BlackMATE should be in /usr/share/themes/BlackMATE/gtk-3.0/assets if they are missing or elsewhere you won't see the checkboxes etc.

Mno-hime commented 5 years ago

Here are lists of content of mate-themes v3.22.19, and, respectively, v3.22.20:

mate-themes_3.22.19.txt mate-themes_3.22.20.txt

Theme images seem to be where they should.

We have following version of GTK 3: library/desktop/gtk3@3.24.10-2018.0.0.0.

rbuj commented 5 years ago

I couldn't reproduce your issue with BlackMATE on oi-hipster 2019.04:

git clone https://github.com/mate-desktop/mate-themes.git
cd mate-themes/
git checkout gtk3.22
sudo cp desktop-themes/BlackMATE/gtk-3.0/gtk-widgets.css /usr/share/themes/BlackMATE/gtk-3.0/gtk-widgets.css

Screenshot at 2019-09-23 00-15-53

raveit65 commented 4 years ago

I am late to party. See my comment at https://github.com/mate-desktop/mate-themes/pull/259#issuecomment-589967585 For the moment you can add ~/.config/gtk-3.0/gtk.css with that content to your home dir, to fix tooltip issue.

tooltip,
tooltip.background,
.tooltip,
.tooltip.background {
    border-radius: 2px;
}

This will override all themes at /usr/share/themes/