Traditional and Menta theme families: Resolved Caja sidebar display issues (resolves #274)

[thesquash]

Several lines in the Traditional and Menta theme families, seemingly related to historical overlay scrolling issues, have been removed. These lines were causing the doubling in height of some rows in the Caja Places, Tree, History and Bookmarks sidebars in all themes, and the chopping off of the left side of said Caja sidebars in the Traditional family of themes.

Please see issue #274 for more discussion about this theming regression.

[raveit65]

I am theme artist of Of Menta an i said already, that i will take a look at it. Thank you

[raveit65]

@thesquash With your change the location GtkTreeView looks weird for me with Menta themes. I miss the vertical padding. And i think there is a bug in GtkTreeView itself if you use different values for horizontal and vertical padding. I noticed this since gtk+-3.20 or so. Can you update your PR for Menta please?

/* treeview rows */
.caja-side-pane treeview.view {
    padding: 2px;
}

Bookmark and location views looking fine when using same horizontal and vertical values.

Edit: For me there is too much space on the left side of location view. For this reason i added the different h/v padding setting. But i think this needs to be fixed in another way, probably directly in code. Any way, i can live with this compromise ;)

[raveit65]

I agree with your code change for Traditional themes. So only change for Menta themes needs update. @sc0w Ok for you?

[thesquash]

Fair enough @raveit65, I just added the padding back in.

It's undoubtedly a GTK+ bug. In my spare time I'll check into it.

Thanks!