mate-desktop / mate-themes

Official themes for the MATE desktop
https://mate-desktop.org
GNU Lesser General Public License v2.1
75 stars 45 forks source link

border-radius for themes preview #300

Open luigifab opened 2 years ago

luigifab commented 2 years ago

From mate-appearance-properties theme tab. Here are screenshots from Fedora Rawhide with Mate 1.26:

image image

As we can see, Traditional and Yaru themes have window border-radius like BlueMenta theme. But for BlueMenta there are no problems (ok, there is a white background color instead of a transparent background). How did you that for BlueMenta?

Related issue: https://github.com/mate-desktop/mate-control-center/issues/519

raveit65 commented 2 years ago

I think it depends on the version of the metacity.xml.

[rave@mother mate-themes]$ ls desktop-themes/BlueMenta/metacity-1/ | grep metacity
metacity-theme-1.xml
metacity-theme-2.xml
metacity-theme-3.xml
[rave@mother mate-themes]$ ls desktop-themes/TraditionalOk/metacity-1/ | grep metacity
metacity-theme-1.xml
[rave@mother mate-themes]$ ls desktop-themes/YaruOk/metacity-1/ | grep metacity
metacity-theme-1.xml

Menta themes support version 2/3.

luigifab commented 2 years ago

Good, I found the culprit: https://github.com/mate-desktop/mate-themes/blob/4f32d8ec9714820dc4fa903d919841d91c4360ee/desktop-themes/YaruOk/metacity-1/metacity-theme-1.xml#L203 But for now I didn't found a solution.

lukefromdc commented 2 years ago

I can see this too. Looks like the Yaru themes inherited it from the Traditonal themes upon which they are based

blue-devil-93 commented 2 years ago

Maybe the bug is even partially inside blue menta too. Use a image zoom and youll see that thr background gets expanded over the border to the edges.

But white on normal background has indeed much less contrast than blue. The double border at the edges gets cropped on metacity-/marco once you activate the theme due to the rounded border definition in metacitys xml file. Its solution would be to a) partially rewrite Yaru and Traditional ok xml file providing image assets if necessary and patching the preview mechanism .