BlackMATE-border Theme - Overlooked use of "bar_unfocused.png" for unfocused non-maximized windows

ericmarceau-rogers commented 2 months ago

Expected behaviour

Un-focused windows should all be presented with the same colour tile "bar_unfocused.png", whether maximized or not. Frame_style "normal_unfocused" should incorporate attributes for "titlebar_fill_unfocused".

Actual behaviour

Currently, metacity-theme-3.xml for BlackMATE-border only has directives to show different colour for unfocused windows that are maximized, namely frame_style "normal_max_unfocused"! No similar directive exists for frame_style "normal_unfocused" windows.

Steps to reproduce the behaviour

Use UbuntuMATE 22.04.4 LTS distro installation.
Load published theme set for BlackMATE-border from mate-themes-3.22.26 build.
Open more than one terminal.
Click on one then the other, while looking at the titlebar to observe any colour change (none will appear).
Maximize one window, then click on the non-maximized terminal from the taskbar and compare the titlebar colours (the colour difference will be barely visible, but it is observable).

MATE general version

mate-themes-3.22.26

Package version

mate-themes-3.22.26

Linux Distribution

UbuntuMATE 22.04.4 LTS

Recommended fix

patch for working implementation in attached file: metacity-theme-3.xml__ericmarceau.patch.txt

Related discussion.

Link to bug report of your Distribution (requirement)

Bug report #2077202 submitted on Launchpad.

lukefromdc commented 1 month ago

Commit https://github.com/mate-desktop/mate-themes/commit/23ac3fdda2a7704c0f91a6ff4131d822276240cd fixes this for the normal BlackMATE theme, where it also has become an issue. Will do the same for BlackMATE-border

With my eyes the difference is very hard to spot (you have to focus on it) but it is in fact there, proving the code is working with the before and after test. Tested in marco and even in Wayfire's 3ed party marco-decorator, worked in both.

lukefromdc commented 1 month ago

https://github.com/mate-desktop/mate-themes/commit/df2b819d6cbaa6bff7af8926c2a1b85e4d301934

and

https://github.com/mate-desktop/mate-themes/commit/a85ad3e182612c11885860b76e8950c5e1288633

fixes this for BlackMATE-border. I got the logic reversed on the first commit so had to fix that with a second.

mate-desktop / mate-themes