mate-desktop / mate-utils

GNU General Public License v2.0
39 stars 30 forks source link

Window screenshots are incorrectly sized, resulting in an undesired border #236

Open adatum opened 5 years ago

adatum commented 5 years ago

Expected behaviour

Alt+Print Screen should take a screenshot of only the window in focus.

Actual behaviour

The screenshot area is larger than the window, leaving an undesired border. In the image below, some of the desktop background is showing as a border around the window screenshot. mate_window_screenshot

I'm not certain, but the problem seems to be limited to windows. Dialog boxes, such as "About MATE" show up correctly without the undesired border in window screenshots.

Steps to reproduce the behaviour

Open any window, eg. file manager, browser, terminal, and take a window screenshot with Alt+Print Screen.

MATE general version

1.22.1

Package version

1.22.1-1.fc30

Linux Distribution

Fedora 30 MATE

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/77051289-window-screenshots-are-incorrectly-sized-resulting-in-an-undesired-border?utm_campaign=plugin&utm_content=tracker%2F1509859&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1509859&utm_medium=issues&utm_source=github).
lukefromdc commented 5 years ago

This is CONFIRMED here, and note that it happens only when the window borders included in the screenshot and (if using marco) compositing is used. I can see it with marco(w compositing) and with metacity, and I'm pretty sure that what's happening is the screenshot is picking up both visible and invisible borders (used for resize from outside the visible border area starting with marco 1.22.2/1.23/1 and also used in metacity).

This does NOT happen with IceWM, which does not support invisible borders, and with compiz-reloaded mate-screenshot can't pick up the borders at all. Thus, this is a surprise side effect of https://github.com/mate-desktop/marco/pull/503 , which solved the problem of windows being very hard to resize with the mouse in some metacity themes

adatum commented 5 years ago

Thanks for confirming. Now that you mentioned it, I just noticed the invisible window borders that make it much easier to resize windows. The size of the invisible borders does seem to match the undesired screenshot borders.

I don't have a specific date when the issue was first noticed, but it appeared only fairly recently and does seem to agree with the invisible border feature's merge and eventual release.

raveit65 commented 5 years ago

Latest marco in fedora support invisible borders. https://koji.fedoraproject.org/koji/buildinfo?buildID=1288352 marco-1.22.2-1.fc30

* Mon Jun 17 2019 Wolfgang Ulbrich <fedora@raveit.de> - 1.22.2-1
- update 1.22.2 release
- add support for invisible borders

And yes , i can confirm this.

raveit65 commented 5 years ago

It's not the same but you can exclude the window-decoration from screenshots.

[rave@mother ~]$ gsettings get org.mate.screenshot include-border
false

Bildschirmfoto zu 2019-07-17 09-14-40

This confirms that it is a problem with the new invisible-borders.

clefebvre commented 5 years ago

@monsta also related you mentioned were the little theme thumbs in the theme selector.

lukefromdc commented 5 years ago

I can confirm an "ears" issue with corners on theme thumbnails. which is a transparency issue

adatum commented 4 years ago

This issue is still present with MATE 1.22.2 and Fedora 31.

InfoLibre commented 4 years ago

I've got this bug with Kazam, mate-screenshot, ScreenGrab and Shutter on Linux Mint MATE 19.3.

adatum commented 4 years ago

Issue persists in MATE 1.24.0 and Fedora 32.

Any progress on this?

InfoLibre commented 4 years ago

Websites with ugly screenshots began to appear : https://tugaleres.com/2020/07/13/linux-mint-migration-de-la-version-19-3-vers-la-version-20/ :jack_o_lantern:

lukefromdc commented 3 years ago

As a workaround, you should be able to temporarily turn compositing off in marco from "Windows" in mate-control-center, so as to suppress the invisible borders and keep the wide,dark border off your screenshot. Simpler to exclude the window decorations unless you need them to be shown however,

davidhedlund commented 1 year ago

As a workaround, you should be able to temporarily turn compositing off in marco from "Windows" in mate-control-center, so as to suppress the invisible borders and keep the wide,dark border off your screenshot. Simpler to exclude the window decorations unless you need them to be shown however,

Thanks, this could be executed with: gsettings set org.mate.Marco.general compositing-manager false