mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
158 stars 66 forks source link

Pluma ignores interface consistency #525

Closed jEsuSdA closed 4 years ago

jEsuSdA commented 4 years ago

Expected behaviour

When opening Pluma I spect to have a uniform look with the same font size in all GTK apps.

Here is how Pluma 1.20 looks:

imagen

All the interface looks as expected and with the fonts in correct size.

Actual behaviour

But in 1.22 and 1.24 versions I get this:

imagen

Pluma ignores all the configuration about fonts. Not the same font family and not the same font size. So it looks like more similar to Frankenstein than the rest of my apps XD.

Steps to reproduce the behaviour

Here is my GTK configuration:

imagen

imagen

imagen

MATE general version

2.24

Package version

1.24.0-1

Linux Distribution

Debian Testing

I hope you could solve this. It is very annoying not to be able to upgrade pluma since 1.20 version. Thanks a lot!

BwackNinja commented 4 years ago

I encountered this issue today. The source is: https://github.com/mate-desktop/pluma/commit/ca00615b510549a4abfe44f7b1f97485e1e9f804, which then changes all labels in the application based on the font set in org.mate.interface -> "font-name" (/org/mate/desktop/interface/font-name), overriding any changes done set elsewhere, including the css of your gtk theme.

The goal of that logic is to avoid setting the font on the context menu to monospace, but given the equivalent gedit code, https://github.com/GNOME/gedit/blob/master/gedit/gedit-view.c that's unnecessary.

I'll write a patch for it sometime this week unless someone else beats me to it.

jEsuSdA commented 4 years ago

Thank you so much for researching about this bug. I hope this could be fixed soon.

Thanks a lot!

BwackNinja commented 4 years ago

I created https://github.com/mate-desktop/pluma/pull/582 if you'd like to test my changes.

raveit65 commented 4 years ago

For stable branch https://github.com/mate-desktop/pluma/commit/cc755f3bd8d627c88a085f154a678f19e88d2710