search

mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
158 stars 66 forks source link

bring back open file from location dialog #535

Closed mbkma closed 4 years ago

mbkma commented 4 years ago

That feature was removed from gedit in 2009. I know that there is an option in file-chooser-dialog to open a file from location (ctrl+l), but most people don't. And this dialog here is fast accessible and features history entries. It is mostly the same code as 2009, but with some deprecation fixes.

Screenshot at 2020-04-05 10-39-27

Fixes #210

rbuj commented 4 years ago

IMHO it's redundant with the feature that currently offers GtkFileChooserDialog.

Openning a location on Open Location dialog

Screenshot at 2020-04-16 15-22-01

Openning a location on GtkFileChooserDialog

Screenshot at 2020-04-16 15-22-49

rbuj commented 4 years ago

I saw also that Open Location dialog is not modal, i.e. I was able to access to pluma main menu once the Open Location dialog was displayed. It may be addressed with gtk_window_set_transient_for.

mbkma commented 4 years ago

fair enough - closing this PR. Help Keyboard_Shortcuts should be updated though. Screenshot at 2020-04-16 16-15-00

raveit65 commented 4 years ago

Named Open location is misleading, you can only open an URI of an file with this dialog. Eg. /home/rave/rpmbuild/SOURCES/pluma_0001-smart-converter-Fix-memory-leaks.patch But using ~/rpmbuild/SOURCES/pluma_0001-smart-converter-Fix-memory-leaks.patch doesn't work. It should named open from location which is basicly the same as with GtkFileChooser.

rbuj commented 4 years ago

@raveit65 I can switch between location entry and breadcrumbs with ctrl+l, then I can open a relative file location like ~/test.txt.

Edit screenshot:

Captura de Pantalla 2020-04-16 a les 16 43 24
rbuj commented 4 years ago

The location entry will also open if you press '.', '/' or '~'.

raveit65 commented 4 years ago

Good that it works with GtkFileChooser, it didn't work with the dialog from PR. Any way, PR is obsolete and closed.

raveit65 commented 4 years ago

Ok, confirmed crt+L works with GtkFileChooser. So, do we need to revert the shortcut with your new PR? Or is this shortcut in GtkFileChooser code? Maybe only help needs updating?

raveit65 commented 4 years ago

Got it, new PR is only about help :)