Merge gio document loader and saver into document loader and saver

mate-desktop / pluma

A powerful text editor for MATE

http://www.mate-desktop.org

GNU General Public License v2.0

157 stars 65 forks source link

Merge gio document loader and saver into document loader and saver #562

Closed mbkma closed 4 years ago

mbkma commented 4 years ago

Backport from: https://gitlab.gnome.org/GNOME/gedit/-/commit/4bd74a1f47a3fa41385ffae3bb78aeb5afabb564 See: https://bugzilla.gnome.org/show_bug.cgi?id=617215

I think I need this backport for a future PR I want to make. Apparently having a separate gio-document-loader/saver is not needed anymore.

raveit65 commented 4 years ago

It seems that everything works like before in a quick test.

mbkma commented 4 years ago

@raveit65 It only does look weird on Github, not in Pluma (which may be caused bay tabs + spaces, but this was the original coding style) Screenshot at 2020-07-15 13-28-33

raveit65 commented 4 years ago

Da hast Du leider Pech gehabt das du alten schlecht formatierten Code angefasst hast :) Nun ist es aber neu geschriebener Code. Es wäre schön wenn es auch auf github schön aussieht. Danke

Edit: NO tabs no pain....

mbkma commented 4 years ago

@raveit65 this was the most difficult thing I've ever done ;)

raveit65 commented 4 years ago

One indent issue is missing :) Any way, i will start to test the resulting patch again. Btw. when adding .diff or .patch to the end of PR link in browser you see the raw formatted version.

raveit65 commented 4 years ago

Am i right that behaviour of pluma isn't change with this PR? In result all is fine when it works like before?

mbkma commented 4 years ago

Yes nothing should have changed. I just merged the abstract class into the concrete class, without actual code changes. I don't even know why the abstraction was needed, but it seems it is not needed anymore.

mbkma commented 4 years ago

Today I was testing this PR again with diff all files compared to master branch. I overlooked this one mate-commit 90fa9b31bb87135c23253074c7d437896b6698f8. Now everything should be identical. I can squash commits before merge.