search

mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
157 stars 65 forks source link

pluma-document: Fix warning assertion 'G_IS_FILE (file)' failed #564

Closed rbuj closed 4 years ago

rbuj commented 4 years ago

Test: Create a new document, without saving the new document, select a highlight mode

(pluma:84684): GLib-GIO-CRITICAL **: 22:56:46.725: g_file_get_path: assertion 'G_IS_FILE (file)' failed
fopen: Bad address
raveit65 commented 4 years ago

@mbkma Any concern left?

raveit65 commented 4 years ago

Building with "ubuntu:rolling" which is actual ubuntu-20.04 works fine, see https://travis-ci.org/github/mate-desktop/pluma/builds/721265306 The rolling tag is used for latest stable release in ubuntu and latest is used by LTS releases. https://hub.docker.com/_/ubuntu/ So, rolling is what we should use here for stable builds. Honestly, i don't want to spend my spare time to find out why distclean is broken in hottest ubuntu docker image branch.

ERROR: files left in build directory after distclean:
./docs/reference/pluma.actions
make[1]: *** [Makefile:814: distcleancheck] Error 1
make[1]: Leaving directory '/rootdir/pluma-1.25.0/_build/sub'
make: *** [Makefile:743: distcheck] Error 1

That Mate runs well with development package database is a job for distro maintainer like me, @flexiondotorg or others. I will update master branch with the rolling tag.

raveit65 commented 4 years ago

Just rebased with master.

raveit65 commented 4 years ago

Travis builds are fixed now.