mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
157 stars 65 forks source link

Remove changecase plugin. Functionality is provided by GtkSourceView. #565

Closed mbkma closed 4 years ago

mbkma commented 4 years ago

Add shortcuts to docbook. Remove Change Case Plugin. New shortcuts: Screenshot at 2020-07-26 10-13-50

sc0w commented 4 years ago

I notice the same shortcuts in gedit, but I don't have the ~ key (spanish keyboard), and I need to press controlAlt Gr4, maybe is better a combination which works in the same way in all keyboards?

mbkma commented 4 years ago

@rbuj thanks, I adopted your changes. @sc0w I changed the shortcuts to Screenshot at 2020-08-02 22-27-49

sc0w commented 4 years ago

@mbkma 35 commits behind mate-desktop:master , can you update it please?

mbkma commented 4 years ago

@sc0w done

sc0w commented 4 years ago
pluma-ui.h:106:2: warning: missing initializer for field 'accelerator' of 'GtkActionEntry' {aka 'const struct _GtkActionEntry'} [-Wmissing-field-initializers]
  106 |  { "ChangeCase", NULL, N_("C_hange Case") },
      |  ^
mbkma commented 4 years ago

This is a warning that appears for all other toplevel GtkActionEntries as well, maybe its better to fix in another PR? I think just adding NULL,NULL,NULL, i.e. { "ChangeCase", NULL, N_("C_hange Case"), NULL, NULL, NULL} would do it.

rbuj commented 4 years ago

@mbkma Will you do it in another PR including the other cases? #568 (If so, I will remove #568)

mbkma commented 4 years ago

I just applied { "ChangeCase", NULL, N_("C_hange Case"), NULL, NULL, NULL} @rbuj I think #568 is fine

rbuj commented 4 years ago

I think there's nothing remaining to be done, @sc0w do you agree?