search

mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
157 stars 65 forks source link

pluma-time-plugin: Use g_date_time_format #569

Closed rbuj closed 4 years ago

rbuj commented 4 years ago

based on https://github.com/GNOME/gedit/commit/121f02a3ea066565eeae5dd42868f822ecce4924 and https://github.com/GNOME/gedit/commit/ef65fda074d58296b8c919f64744e48a1e610123

rbuj commented 4 years ago

I think i have a deja vu...

rbuj commented 4 years ago

A rewritten function that does not use tabs for indent, where is the code formatting issue?

sc0w commented 4 years ago

A rewritten function that does not use tabs for indent, where is the code formatting issue?

It is ok for you, not for me. Tabs or spaces for indent in all the file is the right way for me.

Thanks for new commit :)

raveit65 commented 4 years ago

Hmm, for me the last commit isn't necessary. I mean replacing tabs with spaces is Ok , but starting a line with 8 spaces is really wasteful. And last commit has indent issues. Using only the first commit is OK for me..... ....or you fix the indent problems.

rbuj commented 4 years ago

Hmm, for me the last commit isn't necessary.

I removed the last commit.

raveit65 commented 4 years ago

I will fix formatting in pluma after i did it for mate-applets.