search

mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
157 stars 65 forks source link

add terminal plugin #570

Closed mbkma closed 3 years ago

mbkma commented 4 years ago

Full credits go to gnome, I just changed some things to the pluma api. I think a terminal is a very useful plugin, especially when writing latex, where one needs to compile a lot. Other terminal plugins for pluma I found on the internet are very out of date and not easy installable for the end-user.

raveit65 commented 4 years ago

@mate-desktop/core-team Maybe, it is time to start with an extra package pluma-plugins ?

sc0w commented 4 years ago

@raveit65 I agree, I have no problem if someone like to work in that

raveit65 commented 4 years ago

@mbkma Do you plan to add more plugins to pluma? Or is this the last one?

mbkma commented 4 years ago

@raveit65 I do not know yet. In October I will have some free time, maybe then I can port more plugins to pluma.

raveit65 commented 4 years ago

My question is more if we should start with extra package pluma-plugins? Or do you prefer to split it later when someone really add new plugins?

mbkma commented 4 years ago

@raveit65 I prefer to split it later when someone really add new plugins. The terminal-plugin then can be a part of the new pluma-plugin package. If you agree, you can close this PR.

raveit65 commented 4 years ago

Ok, we can just leave it open as a "sleeper" PR.

mbkma commented 3 years ago

Until now forked 3 gedit plugins: codecomment, synctex and terminal. I created a package which you can include in mate if you want: https://github.com/mbkma/pluma-plugins. For more complex plugins, more changes to pluma are necessary which I didn't manage to get to build properly yet.

raveit65 commented 3 years ago

Nice, i can include it to Mate. Do you like to be become maintainer for pluma-plugins and pluma?

mbkma commented 3 years ago

It would be a honour for me :)

mbkma commented 3 years ago

@raveit65 but dont include it yet I still have to test some things

raveit65 commented 3 years ago

Too late, it's already done. I send you an invitation and you can work now directly at https://github.com/mate-desktop/pluma-plugins. No PR needed for first adjustments. Or should i delete the repo?

mbkma commented 3 years ago

It doesn't build right now. But I think I can fix it within the next hours. So if that is no problem, you don't have to delete the repo. EDIT: Building pluma-plugins works now, but I had to disable building the po directory. I will investigate how to fix that.

mbkma commented 3 years ago

See https://github.com/mate-desktop/pluma-plugins/pull/1. Maybe when https://github.com/mate-desktop/pluma-plugins/pull/1 is merged you can create your own repository pluma-plugins such that it is not forked from mine (looks nicer if it is directly from MATE).

raveit65 commented 3 years ago

I think renaming/renaming-back should decouple it from your repo

mbkma commented 3 years ago

The terminal plugin is part of the new package pluma-plugins.