search

mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
157 stars 65 forks source link

Fix issue #525 setting textview font css based on gedit and gtk/gtkfontbutton.c #582

Closed BwackNinja closed 3 years ago

BwackNinja commented 3 years ago

Based on

https://gitlab.gnome.org/GNOME/gedit/-/commit/100b91ee49feeaf848ff1486e952d27394fcbf74

and

https://gitlab.gnome.org/GNOME/gedit/-/merge_requests/100

raveit65 commented 3 years ago

Commit message needs work. Please do not use links in commit header, put them in commit body. And use a short description what the commit does, perhaps use commit message from gedit?

 Fix issue #525 setting textview font css based on gedit and gtk/gtkfontbutton.c

This is what you did but not a description what the commit does ;)

BwackNinja commented 3 years ago

Is that better? I didn't use the commit message from gedit because this change isn't about removing deprecated usage of gtk_widget_override_font like the original was.

raveit65 commented 3 years ago

Excellent. A meaningful commit message is important when searching in git history. Thanks.

BwackNinja commented 3 years ago

It's a bug in your theme, Clearlooks-Phenix.

Your theme is missing:

.context-menu { font: initial; }

Adwaita theme reference: https://gitlab.gnome.org/GNOME/gtk/-/blob/gtk-3-24/gtk/theme/Adwaita/_common.scss#L4709

Original commit in gtk introducing that and specifically mentioning this situation with gedit: https://gitlab.gnome.org/GNOME/gtk/-/commit/7e9372bafaeeb37dd4d8d78fff3a914731784f81

raveit65 commented 3 years ago

@BwackNinja Can you do a PR for 1.24 branch please? A simply cherry-pick doesn't work. We can consider this as bugfix which belongs in stable branch.