search

mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
157 stars 65 forks source link

Fix line numbers menu: use g_settings_bind correctly #585

Closed mbkma closed 3 years ago

mbkma commented 3 years ago

Test: right-click on line-numbers

raveit65 commented 3 years ago

@mbkma

Test: right-click on line-numbers

What should happen? Here behaviour is same as before. No context menu or what ever you expect. Beside from that pluma builds and runs fine.

mbkma commented 3 years ago

@raveit65 before it crashes / after it displays the context menu.

Screenshot at 2020-11-22 13-49-12

Also see https://developer.gnome.org/gio/stable/GSettings.html#g-settings-bind (the key should be the second argument).

raveit65 commented 3 years ago

I get no crash or the context menu w/wo the commit. Maybe HIDPI related? Any way, fix is fine. I will cherry-pick it to stable.

mbkma commented 3 years ago

@raveit65 I don't think this issue exists in 1.24.

raveit65 commented 3 years ago

Ok, good. Cherry-picking doesn't clean apply.

raveit65 commented 3 years ago

Good news, travis CI builds starting immediately again :) https://travis-ci.org/github/mate-desktop/pluma/builds/745209847

rbuj commented 3 years ago

culprit 2edb465b646f671f3372c70f020bd3d3076e86ad