search

mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
156 stars 64 forks source link

pluma: Use EXIT_SUCCESS macro instead of int value (portability) #608

Closed rbuj closed 3 years ago

cwendling commented 3 years ago

Me being me, I can't help it but mention that exit(0) is perfectly equivalent to exit(EXIT_SUCCESS):

N1570 — Committee Draft — April 12, 2011 — ISO/IEC 9899:201x (emphasis mine):

§ 7.22.4.4 The exit function […] If the value of status is zero or EXIT_SUCCESS, an implementation-defined form of the status successful termination is returned. […]

raveit65 commented 3 years ago

Me being me, I can't help it but mention that exit(0) is perfectly equivalent to exit(EXIT_SUCCESS):

As a system-integrator i don't see why this change is needed :) Well, it looks like an easy change. @rbuj @cwendling Can you explain why?

rbuj commented 3 years ago

For greater portability, you can use the macros EXIT_SUCCESS and EXIT_FAILURE for the conventional status value for success and failure, respectively.

https://www.gnu.org/software/libc/manual/html_node/Exit-Status.html

cwendling commented 3 years ago

As a system-integrator i don't see why this change is needed :)

It is not needed.

Well, it looks like an easy change.

It is, the change itself looks perfectly fine. It's just that it doesn't change anything behavior-wise (for any standards-compliant systems, at least).

This enhances portability

It does not change anything to that regard in a conforming C implementation. I'm too lazy to check right now, but I'm pretty sure that was already defined as equivalent in C89.

and readability.

That's subjective and fair. I have absolutely no problem with plain integers because it's so widely used, but I can see why one would want to use named constants.

To summarize: Per C11 (and probably older standards) and POSIX (according to GCC docs), this PR does not change anything. It was fine before, it's fine after. I do not have anything against this change, I just felt the need to mention that it does not improve anything, given at least a non-prehistoric environment (if somebody can find a system that doesn't follow either POSIX nor the C standard on that, I'd stand corrected -- and simply yell angrily at that system).

rbuj commented 3 years ago

I just want to highlight 2 sentences from the exit(3) man page, which explain why standard constants are preferred to int values.

$ man 3 exit

The C standard specifies two constants, EXIT_SUCCESS and EXIT_FAILURE, that may be passed to exit() to indicate successful or unsuccessful termination, respectively.

The use of EXIT_SUCCESS and EXIT_FAILURE is slightly more portable (to non-UNIX environments) than the use of 0 and some nonzero value like 1 or -1. In particular, VMS uses a different convention.