search

mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
158 stars 66 forks source link

Introduce PlumaWindowActivatable, PlumaAppActivatable, PlumaViewActivatable #615

Closed mbkma closed 3 years ago

mbkma commented 3 years ago

These interfaces are for extensions that should be activated against a window/app/view.

Backport from

For indentation please review the "tab to spaces" commit.

rbuj commented 3 years ago

The code formatting of the other files, such as pluma/pluma-window.c and pluma/pluma-view.c, should be in another commit.

rbuj commented 3 years ago

I think we can remove the dist-hook from pluma/Makefile.am:

diff --git a/pluma/Makefile.am b/pluma/Makefile.am
index 8d3103f..475f1ab 100644
--- a/pluma/Makefile.am
+++ b/pluma/Makefile.am
@@ -145,8 +145,10 @@ libpluma_c_files =             \
    pluma-window-activatable.c  \
    plumatextregion.c

+nodist_libpluma_la_SOURCES =       \
+   $(BUILT_SOURCES)
+
 libpluma_la_SOURCES =          \
-   $(BUILT_SOURCES)        \
    $(libpluma_c_files)     \
    $(BACON_FILES)          \
    $(POSIXIO_FILES)        \
@@ -206,9 +208,6 @@ typelib_DATA = $(INTROSPECTION_GIRS:.gir=.typelib)
 CLEANFILES += $(gir_DATA) $(typelib_DATA)
 endif

-dist-hook:
-   cd $(distdir); rm -f $(BUILT_SOURCES)
-
 BACON_DIR=$(srcdir)/../../libbacon/src/
 BACON_FILES=bacon-message-connection.h bacon-message-connection.c
mbkma commented 3 years ago

The code formatting of the other files, such as pluma/pluma-window.c and pluma/pluma-view.c, should be in another commit.

For indentation please review the "tab to spaces" commit.

rbuj commented 3 years ago

There is a typo error in 1st commit title and PR title: PlumaAppAcitvatable

raveit65 commented 3 years ago

@mbkma So, this is independent from any other PR and should be merged first?

mbkma commented 3 years ago

@raveit65 yes, this are the new interfaces the other PRs depend upon, so this PR should be merged first

mbkma commented 3 years ago

Note that this PR introduces api changes, so all plugins for pluma need to be updated

raveit65 commented 3 years ago

Ahh......Ok......i understand :P Before: Pluma-good After: pluma-bad So filebrowser-modul needs updating and probably all others.