search

mate-desktop / pluma

A powerful text editor for MATE
http://www.mate-desktop.org
GNU General Public License v2.0
158 stars 66 forks source link

Typescript support #681

Closed golu7679 closed 1 year ago

golu7679 commented 1 year ago

Expected behaviour

Does pluma support Typescript?

Actual behaviour

Steps to reproduce the behaviour

image

When I click on bottom right language select button then their is no option for typescript.

MATE general version

1.24.1

Package version

Linux Distribution

Link to bugreport of your Distribution (requirement)

lukefromdc commented 1 year ago

Pretty sure that's controlled by what GtkSourceView supports

golu7679 commented 1 year ago

can you add support for typescript language?

lukefromdc commented 1 year ago

We are not the maintainers of GtkSourceView, GNOME is https://gitlab.gnome.org/GNOME/gtksourceview Thus nothing we can do on this end

golu7679 commented 1 year ago

I think they support typescript https://gitlab.gnome.org/GNOME/gtksourceview/-/blob/master/data/language-specs/typescript.lang

lukefromdc commented 1 year ago

In which version? We are using GtkSourceView 4, last tagged version is 5.9.0. Changing major versions of an underlying library usually involves some porting work. I do not know much about this part of the code, so I do not know if the newer versions require GTK4 (poorly suited to MATE) or not.

https://wiki.gnome.org/Projects/GtkSourceView

golu7679 commented 1 year ago

okay

lukefromdc commented 1 year ago

First tagged release after the commit you mention is 5.4.2 https://gitlab.gnome.org/GNOME/gtksourceview/-/tags/5.4.2 while we are on the major version 4 series (I have 4.8.4 on Debian Unstable here)

lukefromdc commented 1 year ago

Installing libgtksourceview-5-dev on Debian Unstable also requires installing libgtk-4-dev, indicating the package is only usable with Gtk4 which we will not be porting to anytime soon. This makes sense, as libgtksourceview extends GtkTextView, meaning it has to be compatable with the GTK version in use.

For us to ever support typescript or anything else not now in libgtksourceview-4, GNOME would have to backport commits supporting them. If they did, such support would automatically be added simply by using any version of libgtksourceview-4 released after that backport, with no change on our part.

Closing as there is nothing we can do on this end short of a Gtk4 port

golu7679 commented 1 year ago

okay Thankx