matecat / MateCat

MateCat is an AI driven translation tool for language industry professionals. Matecat makes machine translation post-editing and project outsourcing easy.
http://www.matecat.com
GNU Lesser General Public License v3.0
362 stars 166 forks source link

Refactoring shortcuts #3417

Open riccio82 opened 1 week ago

riccio82 commented 1 week ago

https://app.asana.com/0/1134617950425092/1207324995991288

gitguardian[bot] commented 20 hours ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [9120561](https://dashboard.gitguardian.com/workspace/110635/incidents/9120561?occurrence=142853920) | Triggered | Generic Password | 0a5e1503714862f564d18e65a44d6bf7e0afad7a | public/js/cat_source/es6/components/projects/JobMenu.test.js | [View secret](https://github.com/matecat/MateCat/commit/0a5e1503714862f564d18e65a44d6bf7e0afad7a#diff-01adfd8883d31be5512ed1a3d3c5443b64892501d48ac2a3dd72b544d9436921L253) | | [9120561](https://dashboard.gitguardian.com/workspace/110635/incidents/9120561?occurrence=142853921) | Triggered | Generic Password | 0a5e1503714862f564d18e65a44d6bf7e0afad7a | public/js/cat_source/es6/components/projects/JobMenu.test.js | [View secret](https://github.com/matecat/MateCat/commit/0a5e1503714862f564d18e65a44d6bf7e0afad7a#diff-01adfd8883d31be5512ed1a3d3c5443b64892501d48ac2a3dd72b544d9436921R250) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.