search

mateidavid / fast5

A C++ header-only library for reading Oxford Nanopore Fast5 files
MIT License
53 stars 16 forks source link

Header organization #15

Closed 0xaf1f closed 7 years ago

0xaf1f commented 7 years ago

I noticed while reorganizing that f5pack includes logger.hpp, but doesn't need need to since that's included by fast5.hpp, so I removed those lines in the first commit since it's a logically separate change.

The second commit does a minimal separation. The third commit is more comprehensive, but I'm not sure whether you'd agree to it, in which case you can just cherry-pick the first two commits.

I haven't tested these myself, but I see you're running Travis, so i'll check those results and make adjustments if needed.

0xaf1f commented 7 years ago

Ok, passes now.

jts commented 7 years ago

Thanks, will look at it on Monday.

On Sat, Sep 30, 2017 at 7:50 PM, Afif Elghraoui notifications@github.com wrote:

Ok, passes now.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mateidavid/fast5/pull/15#issuecomment-333343781, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXxn5QRXLXZS_e6w_CqReKRTYuGDvbpks5sntPXgaJpZM4PpuLj .

jts commented 7 years ago

Merged, thanks for the PR!

0xaf1f commented 7 years ago

Thanks! Would you mind tagging a new release?

jts commented 7 years ago

Done, tagged v0.6.3

0xaf1f commented 7 years ago

Awesome. Thank you