search

matejak / argbash

Bash argument parsing code generator
Other
1.4k stars 62 forks source link

Fix RPM packaging issues #39

Closed sgallagher closed 6 years ago

sgallagher commented 6 years ago

RPM packaging was failing because the bash-completion installation had two bugs in it:

1) It did not properly install under $(ROOT) which meant that it was trying to install directly in /etc rather than the RPM buildroot. 2) The INSTALL_COMPLETION environment variable had two bugs: first, it was not set ?=, so it couldn't be overriden at the command-line. Second, the test for it only resulted in the directory not being created; as a result, it was still attempting to copy the argbash.sh file into a nonexistent location, which failed.

This patch also updates the RPM packaging.

matejak commented 6 years ago

Thank you very much for your contribution! I will release 2.6.1 with this fixes over the weekend.