mateoconlechuga / cesium

A GUI shell for the TI-84+CE
BSD 3-Clause "New" or "Revised" License
258 stars 17 forks source link

Password Bypass Bug #199

Closed BruceCosgrove closed 3 years ago

BruceCosgrove commented 3 years ago

Calculator: TI-84 Plus CE TI-OS Version: 5.3.0.0037

Hi there!

In upgrading from 3.3.1 to 3.4.1, I have stumbled across a bug with the password protection feature (identical on both versions). Everything happens as you expect when the calculator isn't connected via a USB, but when it is, that's where the bugs come in. While connected, pressing on+stat does not trigger the calculator to turn off, but it does open the password prompt. If the password is failed, it does turn off correctly, but if you turn it back on (and wait for the calculator to let you input buttons because of the USB connection causing some delay) it completely bypasses the password and lets you in without it. Furthermore, if you turn it off and on again, the password prompt doesn't even show up.

I'm guessing the "require password" bit gets reset somewhere in there, which definitely shouldn't happen.

BruceCosgrove commented 3 years ago

I have since found past issues about this. I should've done that first.