search

mateodelnorte / servicebus

Simple service bus for sending events between processes using amqp.
MIT License
420 stars 66 forks source link

set autoDelete to ‘false‘ doesn't work #104

Closed seanxlliu closed 6 years ago

seanxlliu commented 7 years ago

https://github.com/mateodelnorte/servicebus/blob/959ef4f3fca0f69ad421917bf1726cc48ae56c0c/bus/rabbitmq/queue.js#L10

In the following code, if autoDelete is false, the option is simply overwritten by options.ack. autoDelete: options.autoDelete || ! (options.ack || options.acknowledge)

expected behavior:

if autoDelete is set to false, ack won't affect autoDelete. options.autoDelete === undefined ? ! (options.ack || options.acknowledge) : options.autoDelete

seanxlliu commented 7 years ago

[PR] submitted (https://github.com/mateodelnorte/servicebus/pull/105)

seanxlliu commented 7 years ago

Hi @mateodelnorte,

Would you like to have a look at my PR please?

Thanks

seanxlliu commented 6 years ago

The PR has been merged