search

mateodelnorte / servicebus

Simple service bus for sending events between processes using amqp.
MIT License
420 stars 66 forks source link

package middleware honors existing cid; removes cid from message data #68

Closed dermidgen closed 7 years ago

dermidgen commented 8 years ago

This patch has the package middleware honor an existing cid.

However; this changes the behavior referenced: https://github.com/mateodelnorte/servicebus/issues/28#issuecomment-67271130

Correlation id will be kept as a part of the core message and will not appear in the message data.

mateodelnorte commented 7 years ago

This is something you can do in a custom middleware if you like, but I'm going to refrain from making it default behavior. Doing a delete will have performance and memory implications, as V8 will create a new type for every message that comes through this code path and then create another backing type for it when the delete is called. With potentially thousands of objects per second, this could be a big performance hit - and one that would be non-obvious for people to spot.