search

mateor / auto-patcher

smali patcher for Android code injection
MIT License
74 stars 42 forks source link

OPD/Vanir fail: Camera$Parameters.patch in framework.jar cannot be remedied #274

Closed poo706 closed 10 years ago

poo706 commented 10 years ago

Oooooo that Vanir, always so persnickety.

ROM: http://www.emccann.net/nuclearmistake/VanirAOSPNightlies/toroplus/vanir_toroplus_4.4.2.012214.zip

log: http://pastebin.com/aaCSfB6F

mateor commented 10 years ago

Fixed. I just removed those patches, they should have been added to our ignore/remove lists.

poo706 commented 10 years ago

Hmm, auto_patcher auto-updated as expected, but it went from 3.7.9 to 3.7.9. Then patching failed at the same point with the same error.

mateor commented 10 years ago

Shoot I didnt flip the update flags and mangled the push. Try again now, if you can.

poo706 commented 10 years ago

Keeping you on your toes. ;) All good now, thanks!

poo706 commented 10 years ago

Man, this is proving to be a tough one. Last night I confirmed that the 1/22 Vanir patched successfully, but I didn't install it until today. OPD is causing the camera to FC, even when no permissions are revoked. It does not FC after flashing the auto_patcher restore zip. Similar situation to issue #272?

mateor commented 10 years ago

Okay. Likely I have assumed something to be true that is not. I will fix this for you tonight.

poo706 commented 10 years ago

No rush whatsoever, take your time.

mateor commented 10 years ago

Okay, I just undid my first "fix" and replaced your original patch breakage in the usual manner.

So hopefully you are back up and running. I wrote a quick summation pf my mistake in the commit message if you would like more info.

Thanks!

mateor commented 10 years ago

Thanks, it should be up and running again. Please let me know if it isn't. There is always the possibility that in addition to the mistake I "perpetrated" there is an additional issue with CyanogenMod and I may need to rebuild those patches.

Details on what I did to try and solve the issue are on the commit message. Thanks!

mateor commented 10 years ago

Whoops, that last message was meant for another thread. I was responding from my inbox and got confused! Sorry.

poo706 commented 10 years ago

Had me confused for a second too. Patching was successful, I'll try to install it later and let you know. Appreciate the effort.

poo706 commented 10 years ago

Hate to report this, but the camera is still FC'ing. I tried both 1/22 and 1/25. I grabbed a logcat if that helps: https://www.dropbox.com/s/46ib5jf6rs8mqom/Log_2014-01-25_15-58-29.txt . The camera was opened twice and crashed twice during that log recording period.

mateor commented 10 years ago

Hmmmm...okay. I will take a long look at this tonight. I am getting reports of troubles with CM as well. On Jan 25, 2014 3:30 PM, "poo706" notifications@github.com wrote:

Hate to report this, but the camera is still FC'ing. I tried both 1/22 and 1/25. I grabbed a logcat if that helps: https://www.dropbox.com/s/46ib5jf6rs8mqom/Log_2014-01-25_15-58-29.txt . The camera was opened twice and crashed twice during that log recording period.

— Reply to this email directly or view it on GitHubhttps://github.com/mateor/auto-patcher/issues/274#issuecomment-33301257 .

mateor commented 10 years ago

Okay, I have made new patches and tested them on a vanir rom for a grouper device. No FCs for me, but it does not have a Camera. But it does use the Camera code, so I would think it might be okay.

These are all-new patches, hopefully you have more success. If not, it might take major surgery on the project, so we will see.

poo706 commented 10 years ago

Boom! You got it that time, nice work!

mateor commented 10 years ago

thanks poo!