search

mateoradman / bazarr-bulk

Bazarr Bulk Actions CLI - Bulk sync your subtitles with ease
https://crates.io/crates/bazarr-bulk
MIT License
41 stars 1 forks source link

skip empty/embedded movies/tv-shows #22

Open ajmandourah opened 4 months ago

ajmandourah commented 4 months ago

When the tv show or the movie is unmonitered (and therefore no subtitles are downloaded) the script stops and end the tasks with (no episodes found or something like that.

this is extremely helpful when you are having multiple instances of radarr and sonarr and you sync them with import lists to avoid duplicate entries in a library

I would love to contribute but unfortunatly I don't know rust.

mateoradman commented 4 months ago

Hi @ajmandourah, thank you very much for proposing this enhancement. I am not super familiar with unmonitored entries, so I have a question for you. Does it make sense to always skip unmonitored entries, or is there any value in trying to sync those, too? In other words, do you think it would make sense to add a CLI flag such as --skip-unmonitored or would you skip them by default?

ajmandourah commented 4 months ago

@mateoradman Thank you for the prompt response. regarding your question well that depend on the reason why the show is unmonitered. I would suggest adding the flag you mentioned as it gives more option to the user in case he would want to skip or not.

There is another issue though even with the flag. it seems like the program panics as soon a show have no episods and wont continue syncing the next show. in my case the first show have episodes but the second show is unmonitered ( I have it downloaded in another sonarr instance) and the program is ending the script with no error messege as soon as it reaches the second show. i have more than 100 shows in my library. I did not see this behaviour while syncing movies though as i have movies that is unmonitered.

ajmandourah commented 4 months ago

going through the bazarr api, it seems like if a movie or an episodes already downloaded and have a subtitle which is embedded will still be listed when quering the /episodes endpoint. but these will report file_size and path as null. I didn't go through your code but it would be best if checking these keys and if nil skip these subtitles.

ajmandourah commented 4 months ago

I want to thank you for your efforts. I want also to let you know that i made my own cli tool also for the same purpose albiet in golang (as i feel much comfortable working with it.) and its mainly for syncing, feel free to copy/get inspiration out of it . https://github.com/ajmandourah/bazarr-sync

skipping the embedded subs works.

mateoradman commented 4 months ago

Great job, and thank you! :slightly_smiling_face: