build: add nix support - Githubissues

mateoradman / bazarr-bulk

Bazarr Bulk Actions CLI - Bulk sync your subtitles with ease

https://crates.io/crates/bazarr-bulk

MIT License

30 stars 1 forks source link

Closed matt1432 closed 1 month ago

matt1432 commented 1 month ago

This is a very simple PR to make your project easily available to nix users.

I made it so the builds for nix will automatically pick up the right versions so there is no need for any changes in the future from you.

mateoradman commented 1 month ago

Lovely, thanks a lot! Sorry for my lack of understanding of how Nix works 🙂

I have a few questions:

Should we add documentation to the README file, or is this installation/build method self-explanatory for Nix users?
Also, should I generate and upload Nix builds for every release using a GitHub Action? Do those differ from standard Linux binary executables?

matt1432 commented 1 month ago

No worries, I enjoy nixifying repos!

The installation is self-explanatory for Nix users because this is just a simple package. As long as the user knows how flakes work, they're fine. Explaining how flakes work is definitely out of the scope of this repo.
Nix binaries do differ from standard Linux ones. There is a way to automate a cache binary but this package is pretty small so it won't be necessary. I could add a github action that checks if the nix build works in a separate PR if you'd like.

mateoradman commented 1 month ago

Got it, thanks for the explanation. Merging the PR now.

re 2.: I think that Github Action will not be necessary for now. Thanks anyway!