search

mateosalta / CamCastic-Desktop

Port and rework of linux version of camdesk to python3 pygi gtk3 gstreamer 1.0
GNU General Public License v3.0
5 stars 1 forks source link

Pin? What is it, do we want it, fix it.. ect. #17

Closed mateosalta closed 10 years ago

mateosalta commented 10 years ago

Pinning seems broken, although I can't remember what is does, or why we want it. So, I'll investigate what it was... then see about fixing or not from there (maybe renaming it ~)

mateosalta commented 10 years ago

ok, was looking into it. It is the "always on top" behavior, must be something held over from the port. Here is the relevant message,

In keypress Traceback (most recent call last): File "CamCastic.py", line 177, in pinning self.set_keep_above(False) AttributeError: 'Player' object has no attribute 'set_keep_above' Traceback (most recent call last): File "CamCastic.py", line 175, in pinning self.set_keep_above(True) AttributeError: 'Player' object has no attribute 'set_keep_above'

aking1012 commented 10 years ago

Pin is a mistake to be implemented in the first place. If it's supposed to be visible it should be on top. If it's not supposed to be on top it doesn't need to be visible. The forthcoming window visibility hotkey will make it superfluous and useless as a setting.