search

mateosalta / uvolman-fork

fork of uvolman
GNU General Public License v3.0
5 stars 3 forks source link

V. 0.3.1 no french translation for me #14

Closed gbdomubpkm closed 4 years ago

gbdomubpkm commented 4 years ago

Hi. I don't see the french translation..

mateosalta commented 4 years ago

hm, strange. seems it is not picking up the translation

mateosalta commented 4 years ago

uvolman.mateosalta_0.3.2_armhf.zip fixed

mateosalta commented 4 years ago

Thank you, had no idea they were broken for so long :)

gbdomubpkm commented 4 years ago

Fixed for French (even if everything is not translated). Close if you think it's good.

gbdomubpkm commented 3 years ago

Hi @Anne017 I love your work. It would be really great if you could take some time to update the French translation of this great and essential app. Some strings are not translated. Regards.

ghost commented 3 years ago

Hi @gbdomubpkm , all translatable strings are currently already translated. After testing on my own device, the only strings not translated are things like "sink-input-by-media-role:phone". Do you confirm? If yes, it requires a modification of the Main.qml file by @mateosalta to allow internationalization (i18n.tr() addition), then an update of the .pot file (note the po folder contains two .pot files, most probably coming from the app fork, when only one would be the best practice).

gbdomubpkm commented 3 years ago

Thanks for your quick answer @Anne017 I confirm what you say. Strings not french translated are

And also

mateosalta commented 3 years ago

the problem with the sinks is that those are directly determined by the pulse input names, i need to have it somehow hide those and insdead display a translarable device name. https://github.com/mateosalta/uvolman-fork/issues/4

mateosalta commented 3 years ago

the last two should be translatable, although the english was chosen with dashes to match the gsettings valuse