search

mateosss / matter

Customizable GRUB theme inspired by Material Design
Boost Software License 1.0
865 stars 50 forks source link

Split up helper functions and other cleanup #62

Closed heyzec closed 3 years ago

heyzec commented 3 years ago

Currently, the version of inkscape is being output to stdout for every svg icon the script needs to convert. I was thinking if we should do something about that?

mateosss commented 3 years ago

This looks good.

With inkscape 0.92.3 there is no extra output made by inkscape, however using an appimage with version 1.0.2 gives me something:

[I] Begin Matter install
[I] Build theme from user preferences
[I] Convert icons
Setting _INKSCAPE_GC=disable as a workaround for broken libgc
Fontconfig warning: "/etc/fonts/conf.avail/53-monospace-lcd-filter.conf", line 10: Having multiple values in <test> isn't supported and may not work as expected

** (org.inkscape.Inkscape:27267): WARNING **: 12:50:03.323: Fonts dir '/home/mateo/.config/inkscape/fonts' does not exist and will be ignored.
Background RRGGBBAA: ffffff00
Area 0:0:24:24 exported to 72 x 72 pixels (288 dpi)

# and repeats...

Is that similar to what you are getting? In any case, while it could be silenced with > /dev/null 2>&1 at the end of the command I would prefer for it to not be the first alternative. Could you see why inkscape is throwing those warnings/errors and decide if it is worth silencing everything or if there are flags that tell inkscape to behave properly?

heyzec commented 3 years ago

I thought of making it silence the warnings on subsequent icon converts since the user doesn't need to see those repeated warnings.

Regarding those warnings, I found that the warning Fonts dir '.../.config/inkscape/fonts' does not exist and will be ignored. occurs when the system also has inkscape installed (or used to, the package manager doesn't delete the .config/inkscape folder on uninstall). The AppImage will look into this folder expecting a fonts folder, causing this warnings.

The other warnings I'm still not too sure what's the cause.

mateosss commented 3 years ago

I thought of making it silence the warnings on subsequent icon converts since the user doesn't need to see those repeated warnings.

That seems like a good tradeoff.

mateosss commented 3 years ago

Looks good, thank you!