search

mateosss / matter

Customizable GRUB theme inspired by Material Design
Boost Software License 1.0
865 stars 50 forks source link

Added --all-icon-colors #69

Closed potors closed 2 years ago

potors commented 2 years ago

This option can be called by --all-icon-colors or -aic, which sets the color of each icon, theres no default color, but you still can use -ic to set a global color, or simply not using either. You cannot set more than one color for each icon. I also removed the double enter from all files. The prepare_source_dir() function is no longer responsible for taking care of which icons will be converted, this is now inside the convert_icons_svg2png() function.

potors commented 2 years ago

I ran the script now and saw that I forgot to remove the prints from the list of icons and colors, just remove the lines 194, 200, 208, 209 from matter.py

mateosss commented 2 years ago

Hey! that looks like a nice feature to have. Could you update this PR to only modify lines needed by the feature?

The style changes (things like extra line jumps) are probably out of scope and would be best to discuss them in a new issue. The current style is based on the Black formatter.

potors commented 2 years ago

Could you update this PR to only modify lines needed by the feature?

Now I think it's done, I've changed my code a bit, but now it looks good! Now using -aic it's possible to use _, like the icons, but you need to say the color before use _