materiahq / ngx-monaco-editor

Monaco Editor Library for Angular v6 and above
MIT License
159 stars 35 forks source link

ngServe fails: Error in editor.api.d.ts #21

Closed chedched closed 4 years ago

chedched commented 4 years ago

I've installed the editor as described in detail in the readme file. When I'm now trying to run Angular with the CLI command "ng serve", I get an error:

ERROR in node_modules/monaco-editor/esm/vs/editor/editor.api.d.ts(2167,44): error TS1005: ',' expected.
node_modules/monaco-editor/esm/vs/editor/editor.api.d.ts(2167,54): error TS1005: ',' expected.

For testing purposes I set up an empty angular project, ngx-monaco-editor is the only installed component. Am I doing something wrong here or is this a bug?

jmarc-roy commented 4 years ago

Probably duplicate of #19.

chedched commented 4 years ago

Thank you very much for the super quick reaction! #19 has been filed almost simultaneously, at the time I read through the issues it was not there yet. After downgrading the editor version I get another error: materia-ui-ngx-monaco-editor.js:234 Uncaught TypeError: Object(...) is not a function at materia-ui-ngx-monaco-editor.js:234 at Module../node_modules/@materia-ui/ngx-monaco-editor/fesm5/materia-ui-ngx-monaco-editor.js (materia-ui-ngx-monaco-editor.js:236)

Looks like this is something different though, so I guess this issue can be closed as well.

jmarc-roy commented 4 years ago

Hi @chedched, Do you still have an issue ?