search

materiahq / ngx-monaco-editor

Monaco Editor Library for Angular v6 and above
MIT License
159 stars 35 forks source link

Warning materia-ui-ngx-monaco-editor.js depends on 'css-element-queries'. CommonJS or AMD dependencies can cause optimization bailouts. #52

Closed stagefright5 closed 3 years ago

stagefright5 commented 3 years ago

image

Is this something to be concerned about?

jmarc-roy commented 3 years ago

Hi @stagefright5 , You should not have this error anymore with v5.0.0, I removed this dependency (cf: https://github.com/materiahq/ngx-monaco-editor/blob/master/src/ngx-monaco-editor/package.json). If you are using an older version, you can remove this warning by settings allowedCommonJsDependencies in your angular config file:

"architect": {
  "build": {
    "builder": "@angular-devkit/build-angular:browser",
    "options": {
      "allowedCommonJsDependencies": ["css-element-queries"]
    }
  }
}
stagefright5 commented 3 years ago

Hi @stagefright5 , You should not have this error anymore with v5.0.0, I removed this dependency (cf: https://github.com/materiahq/ngx-monaco-editor/blob/master/src/ngx-monaco-editor/package.json). If you are using an older version, you can remove this warning by settings allowedCommonJsDependencies in your angular config file:

"architect": {
  "build": {
    "builder": "@angular-devkit/build-angular:browser",
    "options": {
      "allowedCommonJsDependencies": ["css-element-queries"]
    }
  }
}

Thanks for the reply. I am waiting for the Monaco load issue #48 to get fixed to upgrade to v5.