search

material-components / material-components-android

Modular and customizable Material Design UI components for Android
Apache License 2.0
16.38k stars 3.07k forks source link

[BottomSheetDialog] Content clipping after orientation change. #2358

Closed enginegl closed 3 years ago

enginegl commented 3 years ago

Description: This issue was introduced in 1.4.0. Bottom sheet width is not invalidated on orientation change without activity recreation. When activity has configChanges=orientation attribute and BottomSheet has been initialized with screen width more than 640dp bottom sheet content width won't be invalidated after orientation change:

Demo project: https://github.com/enginegl/bottom-sheet-issue

Expected behavior: Bottom sheet width should be invalidated on orientation changes according to maxWidth value and actual screen width after orientation change.

Android API version: Any API version

Material Library version: 1.4.0

Device: Android Emulator API 30, Samsung S21 Ultra, Pixel 4 XL, any other device

drchen commented 3 years ago

I cannot reproduce the issue on my end. Is this still reproducible with the latest library version? If so, can you provide a minimal reproducible example to help us debug? Thank you very much!

enginegl commented 3 years ago

@drchen, thanks for looking into this. I cannot reproduce this issue in a demo project after updating to 1.5.0-alpha04.

Do you have any insights about future stable version release date? Thanks!

drchen commented 3 years ago

Hi, we are going to release 1.5.0 beta in a couple of weeks I think. The stable version should be available soon after beta.

I'll close the issue for now. : )