material-components / material-components-android

Modular and customizable Material Design UI components for Android
Apache License 2.0
16.38k stars 3.07k forks source link

[TabLayout] ripple of TabLayout is different from ripple of other components #3157

Open manabu-nakamura opened 1 year ago

manabu-nakamura commented 1 year ago

Description: Ripple of TabLayout is different from ripple of other components. Catalog app: i https://m3.material.io/components/navigation-drawer/specs:

unnamed

https://github.com/material-components/material-components-android/commit/cfc307ed4e6bfee676d5e6d374f76193c5a36edf

Expected behavior: https://m3.material.io/components/tabs/guidelines:

Ripples of TabLayout are inconsistent in https://m3.material.io/components/tabs/guidelines:

lxekp043-18

Minimal sample app repro: Catalog app

Android API version: 33

Material Library version: 1.8.0-beta01

Device: 31.3.14

drchen commented 1 year ago

I actually feel the figure that shows tab states is wrong. Let us double check with our designers.