material-components / material-components-android

Modular and customizable Material Design UI components for Android
Apache License 2.0
16.42k stars 3.08k forks source link

[TimePicker] Japanese translation is not good #3861

Closed manabu-nakamura closed 1 month ago

manabu-nakamura commented 1 year ago

Description: The Japanese translation is not good. Screenshot_20231121_183813

Expected behavior: Screenshot_20231121_215158 (android.app.TimePickerDialog) Screenshot_20231121_184925

Minimal sample app repro: Catalog app (TimePickerMainDemoFragment)

Android API version: 34

Material Library version: 1.12.0-alpha01

Device: Emulator 32.1.15 (API 32)

manabu-nakamura commented 1 month ago

一時的な解決策:これらをres/values-ja/strings.xmlに追加してください

<string name="material_timepicker_select_time">時刻を選択</string>
<string name="material_timepicker_hour">時</string>
<string name="material_hour_24h_suffix">%1$s時</string>
<string name="material_hour_selection">時を選択</string>
pekingme commented 1 month ago

Ah, I think there's a limitation to translate this from English to Japanese. In English, there's no different word representing the "hour" of a moment than the "hour" of a duration. I think it makes sense to add the custom strings as you suggested.

manabu-nakamura commented 1 month ago

I think it's a mistranslation. Because the time picker is a component to choose not the duration of time but the moment of time.

pekingme commented 1 month ago

Yes, agree. I have reported this to our i18n team, who is in charge of the translations. Will keep this issue open until that's updated internally. Thanks for reporting and making the PR.