material-components / material-components-android

Modular and customizable Material Design UI components for Android
Apache License 2.0
16.41k stars 3.08k forks source link

[Slider] Fix slider label not moving #4364

Open manabu-nakamura opened 2 weeks ago

manabu-nakamura commented 2 weeks ago

closes #4342

https://github.com/material-components/material-components-android/commit/967dcd5e071773c2d54ab499065b6690524b5752 is incomplete (https://github.com/material-components/material-components-android/issues/2869#issuecomment-1821123500 is not fixed). If the switch statement in the updateStateTextView() method (https://github.com/material-components/material-components-android/blob/master/catalog/java/io/material/catalog/bottomsheet/BottomSheetMainDemoFragment.java#L272-L292) is commented out, the slider label doesn't move. I want to add a new hook (OnDrawListener) and remove the hooks (OnScrollChangedListener (https://github.com/material-components/material-components-android/commit/5e5eee01bd11f14cf5fbccd17bc18c5926d74774) and OnGlobalLayoutListener (https://github.com/material-components/material-components-android/commit/967dcd5e071773c2d54ab499065b6690524b5752)). Does BaseSlider have a better hook?