material-components / material-components-flutter-codelabs

Codelabs for Material Components for Flutter
212 stars 247 forks source link

lack definition to category in step 4 on MDC-104 #124

Closed jinksw closed 5 years ago

jinksw commented 6 years ago

under the section 'Remove the home app bar' lack definition to category at home.dart which could cause a error when we have done the step 4 of MDC-104 .

there should be a final Category category; in the HomePage class

jinksw commented 6 years ago

actually it could not be a mistake If this step is not a hand by hand step.

melorzhang commented 5 years ago

In home.dart, change the build() function to just return an AsymmetricView:

// TODO: Return an AsymmetricView (104) return AsymmetricView(products: ProductsRepository.loadProducts(category));

should be

In home.dart, change the build() function to just return an AsymmetricView:

// TODO: Return an AsymmetricView (104) return AsymmetricView(products: ProductsRepository.loadProducts(Category.all));

willlarche commented 5 years ago

This is fixed now. Thank you! Let me know if you still see a version that's wrong.