don't lock shrine_images' version

material-components / material-components-flutter-codelabs

Codelabs for Material Components for Flutter

212 stars 247 forks source link

don't lock shrine_images' version #141

Closed mattetti closed 5 years ago

mattetti commented 5 years ago

Don't lock the version of shrine_images otherwise we might end up with unresolvable dependencies:

Because Shrine depends on shrine_images <1.1.1 which requires SDK version >=1.19.0 <2.1.0, version solving failed.

willlarche commented 5 years ago

So, checked with the rest of the team. Not locking to a version is considered an anti-pattern (even if it's a really good brute force here.) Let's keep the package and the pubspec as up-to-date as possible instead. When I check the pubspec, it looks like it's now at 1.1.1 which is a much higher SDK minimum. So I think we should be good.