search

material-components / material-components-flutter-codelabs

Codelabs for Material Components for Flutter
212 stars 247 forks source link

Flat button not respecting buttonTheme when used as ButtonBar child component. #171

Closed maxwillf closed 4 years ago

maxwillf commented 4 years ago

I'm not sure if this is due to flutter version conflict or anything (i'm using the supposedly stable version 1.12.13+hotfix.5) but when i was in the middle of MDC-103 i realized that the shrine app "Next" Raised Button did change correctly when the buttonTheme attribute was changed, but for some reason the "Cancel" Flat Button didn't. Just like the image below shows, the flat button remains the same, as opposed to the brown font showed in the codelab.

image

I found that adding ButtonTextTheme.normal to buttonTextTheme in buttonBarTheme fixes this issue but since there is no sign of this configuration in the 104-complete branch of this codelab, i thought i should create this issue as it might be a bug.

perclasson commented 4 years ago

This has now been fixed and updated.