material-components / material-components-flutter-codelabs

Codelabs for Material Components for Flutter
212 stars 246 forks source link

Fixed error where textTheme and primaryTextTheme was set twice in the 104-complete branch. #249

Closed Z-inator closed 3 years ago

Z-inator commented 3 years ago

While working through the lab, I found a small error where textTheme and primaryTextTheme were set twice in the function _buildShrineTheme() in the file lib>app.dart. I removed the issue code and am contributing to the source.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] commented 3 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Z-inator commented 3 years ago

@googlebot I signed it!

guidezpl commented 3 years ago

Thanks for contributing, I've incorporated your changes in the next codelab update