Open laurencetroyv opened 6 months ago
Regarding the first item you mentioned, they are referring to the error
attribute:
ThemeData _buildShrineTheme() {
final ThemeData base = ThemeData.light(useMaterial3: true);
return base.copyWith(
colorScheme: base.colorScheme.copyWith(
primary: kShrinePink100,
onPrimary: kShrineBrown900,
secondary: kShrineBrown900,
error: kShrineErrorRed,
),
textTheme: _buildShrineTextTheme(base.textTheme),
textSelectionTheme: const TextSelectionThemeData(
selectionColor: kShrinePink100,
));
}
Issues Identified and Resolutions:
1. Use the new text themes
_buildShrineTheme
after an error, but there is no error present.2. Shrink the text
style: theme.textTheme.button
. This generates a warning stating that 'button' is deprecated and should be replaced with 'labelLarge'.textTheme.button
withtextTheme.labelLarge
to avoid the deprecated warning.3. Theme the text fields