material-components / material-components-web

Modular and customizable Material Design UI components for the web
https://material.io/develop/web
MIT License
17.11k stars 2.15k forks source link

[Radio] Incorrect hover/focus state color for unselected radio #4887

Open abhiomkar opened 5 years ago

abhiomkar commented 5 years ago

Bug report

Steps to reproduce

  1. Open http://material-components.github.io/material-components-web-catalog/#/component/radio
  2. Hover over an unselected radio button

Actual behavior

Ripple color is set to secondary for unselected radio button.

Expected behavior

Expected grey ripple color on unselected radio button.

Screenshots

image

Your Environment:

Software Version(s)
MDC Web v3.0.0
Browser any
Operating System any

Additional context

This fix should be fixed along with Feature Target work where all states are set to separate ripple target element.

Danmoreng commented 4 years ago

To add on this issue, the mixin mdc-radio-focus-indicator-color doesn't seem to have an effect at all - onclick the ripple is still using the secondary color.