Open kimurakenshi opened 4 years ago
Any update on this? is it a valid issue or should i close it?
I'll be bringing up this issue with the team during our triage meeting this week. We should have an answer tomorrow 🙂
Thank you!
We definitely think this could be addressed. Adding it to our backlog to investigate
Is this still issue still expected to be fixed? I discovered the same issue today, but noticed this issue had been reported back in 2020.
Bug report
Icon button does not set colors based on theme values properly. Default color doesn't change based on theme color palette and disabled color is always set to
text-disabled-on-light
which is not the best option for a dark theme (screenshot attached).Steps to reproduce
For example:
Actual behavior
Colors are not updated based on theme color palette.
Expected behavior
Colors should be set based on theme color palette.
Screenshots
Possible solution
text-disabled-on-light
ortext-disabled-on-dark
depending on the component's base color.The above comments are just suggestions based on my understanding of the component implementation but i'm not fully aware of the standard and guidelines defined for this components so please ignore this if it doesn't apply.
Workaround
Currently i'm using these styles to achieve what i wanted in case it adds some info to the bug: