search

material-components / material-components-web

Modular and customizable Material Design UI components for the web
https://material.io/develop/web
MIT License
17.14k stars 2.15k forks source link

[Chips] Documentation include 'mdc-chip-trailing-action' class #6729

Open Mr-Pine opened 3 years ago

Mr-Pine commented 3 years ago

The documentation says that: "By default, input chips are removed in response to clicking the trailing remove icon in the chip.", however, this requires the trailing icon tho have the class "mdc-chip-trailing-action" which isn't mentioned in the documentation on material.io once and only appears in https://github.com/material-components/material-components-web/tree/master/packages/mdc-chips/trailingaction.

I think this has to be mentioned in the documentation

brandondiamond commented 3 years ago

Thanks for reporting this bug! This seems like a worthwhile fix -- would you be able to prepare a PR for us to review?

Mr-Pine commented 3 years ago

I already did, forgot to mention it here: #6730