search

material-components / material-components-web

Modular and customizable Material Design UI components for the web
https://material.io/develop/web
MIT License
17.13k stars 2.15k forks source link

[CHIP] missing call to handleAnimationEnd #7277

Open MaximBalaganskiy opened 3 years ago

MaximBalaganskiy commented 3 years ago

Bug report

Chip component does not call foundation.handleAnimationEnd

Your Environment:

Software Version(s)
MDC Web 12.0.0
allan-chen commented 3 years ago

@patrickrodee , could you verify whether this is intended?

patrickrodee commented 3 years ago

This is a bug. The fix is to type the animationend and transitionend handlers in the component (following the existing handlers), then define the handlers in initialSyncWithDOM, listen for the appropriate events ("animationend" for handleAnimationEnd, "transitionend" for handleTransitionEnd), and unlisten when the component is destroyed. Tests would then need to be updated to ensure the handlers are correctly setup and correctly torn down.

patrickrodee commented 3 years ago

This should be reasonable to contribute if anyone wants to.