material-components / material-design-for-wordpress

Material Design plugin for WordPress
78 stars 22 forks source link

Issues when user clicks 2 or 3 times on the same color #379

Closed felipebochehin87 closed 2 years ago

felipebochehin87 commented 2 years ago

Bug Description

Expected Behaviour

Color picker must not disappear and Icon Styles must expand/collapse on each click.

Steps to reproduce

  1. Go to https://dev-mdc-web.pantheonsite.io/wp-admin/customize.php?return=%2Fwp-admin%2Fthemes.php
  2. Click on Material Design Options > Color Palette
  3. Click on the color inside the circle to expand the list of colors available
  4. Click 2 or 3 times on the same color - here the color picker disappears
  5. Click on Icon Styles - see that the options are hidden/displayed, but the grid under the field title is not collapsing

Screenshots

https://user-images.githubusercontent.com/96055551/177779580-426de4ec-55b4-4a30-81a4-0bcfee850510.mp4

Additional context


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

felipebochehin87 commented 2 years ago

@igruszkauy @PatelUtkarsh @emeaguiar @mattchungxwp bug found

emeaguiar commented 2 years ago

Turns out the color picker allows deselecting colors by clicking a second time. I've added a default in case this happens

felipebochehin87 commented 2 years ago

Fixed!

https://user-images.githubusercontent.com/96055551/178462378-575e717b-b292-4eee-b722-e426d5b6b0b7.mp4