search

material-components / material-design-for-wordpress

Material Design plugin for WordPress
78 stars 22 forks source link

[M3] Component Checkbox #402

Closed PatelUtkarsh closed 2 years ago

PatelUtkarsh commented 2 years ago

Feature description

Replace @material/checkbox/dist/mdc.checkbox.css M2 checkbox style with m3.

Checkbox is used within theme and to display material demo component within customizer.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

PatelUtkarsh commented 2 years ago

QA notes :

Checkbox is used on a comment template, for which you will need to view non-logged in post.

Open this in incognito: https://dev-mdc-web.pantheonsite.io/2022/02/01/quia-vel-enim-reprehenderit/

image
igruszkauy commented 2 years ago

Verified via https://dev-mdc-web.pantheonsite.io/2022/02/01/quia-vel-enim-reprehenderit/ in incognito mode

  1. Shows ripple effect: image
  2. I was not able to verify changing color and typography with M3 tokens. From another tab logged w/user, I changed source color and published changes. Then went back to a new guest window and the post is showing the same colors, despite the rest of the site using the new ones. Also tried cleaning cache. https://user-images.githubusercontent.com/2902880/185746441-2c371956-a8dc-4c03-bd5d-98d41b7f7a97.mov
igruszkauy commented 2 years ago

Update: testing updating M2>M3 in a local environment it works well and I was able to update both color and typography.

image

Sending ticket to "review" in case there is something we need to review

PatelUtkarsh commented 2 years ago
  1. Yes ripple is expected.
  2. This is odd, Should we create new ticket if we see this again and move this ticket forward? @igruszkauy