search

material-components / material-design-for-wordpress

Material Design plugin for WordPress
78 stars 22 forks source link

[M3] Ripple #405

Closed PatelUtkarsh closed 2 years ago

PatelUtkarsh commented 2 years ago

Feature description

Replace m2's @material/ripple/dist/mdc.ripple.css style with m3 tokens.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

PatelUtkarsh commented 2 years ago

QA notes:

igruszkauy commented 2 years ago

@PatelUtkarsh verified via: https://dev-mdc-web.pantheonsite.io/ripple-test/ Looks good, both on list mouseover and search/dark mode/hamburger menu icons

The only two things to note,I am not sure are related:

  1. The color in dark mode is very unperceivable: image

vs M2 image

  1. Scroll to top button is looking broken, is this related to button component not being ready? image

Sending ticket to "review" to analyze the above items.

PatelUtkarsh commented 2 years ago

Hello @igruszkauy,

  1. Fixed list color in #433
  2. Button changes are part of #325 - Should be fixed on dev since we merged first version. image
igruszkauy commented 2 years ago

@PatelUtkarsh Verified via:https://dev-mdc-web.pantheonsite.io/new-ripple-test/

  1. List color seems to be the same image
  2. Button seems to be as expected now image
PatelUtkarsh commented 2 years ago
  1. You can compare dark mode list vs new dark mode, colour is more light. @igruszkauy
Before fix After fix
image image
igruszkauy commented 2 years ago

Sending to "Demo" as per comment above.