Core color picker - Githubissues

emeaguiar commented 2 years ago

Summary

Fixes #354

Checklist

[x] My pull request is addressing an open issue (please create one otherwise).
[x] My code is tested and passes existing tests.
[x] My code follows the Contributing Guidelines (updates are often made to the guidelines, check it out periodically).

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2865762665

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

8 of 8 (100.0%) changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.8%) to 72.97%

Totals
Change from base Build 2835107180:	0.8%
Covered Lines:	4683
Relevant Lines:	6292

💛 - Coveralls

PatelUtkarsh commented 2 years ago

Two things on this: @emeaguiar

useSetting is not available on 5.6 WP, which is our minimum support version.
Colour are not showing correctly on latest WP based on generated colors.

PatelUtkarsh commented 2 years ago

For point 2:

I cleaned up the existing global style in order for this to work:

DELETE FROM wp_posts WHERE post_type = 'wp_global_styles'

material-components / material-design-for-wordpress