Open ravichdev opened 3 years ago
Comment by jwold Thursday Jan 14, 2021 at 19:20 GMT
@rodydavis we're wanting to add a setting into Customizer for users to set all text fields as outlined
or filled
.
There are three scenarios we have to account for.
We'd need to have the settings in the appropriate place depending on the scenarios. What do you think?
This also applies to #463.
cc @ravichdev
Comment by rodydavis Friday Jan 15, 2021 at 16:07 GMT
Don't we already do this for post comments in the Customizer?
Comment by jwold Friday Jan 15, 2021 at 21:36 GMT
Correct, that option is already available:
Was thinking something more global. cc @ravichdev whether that could make sense logically.
Comment by jauyong Friday Feb 12, 2021 at 16:29 GMT
@dawidmlynarz to consider where to put the fill vs outline option in the customizer, when you don't have the theme.
Comment by dawidmlynarz Wednesday Feb 17, 2021 at 10:42 GMT
@jauyong Th solution proposed in #463 applies to this task as well. We can discuss it further in this ticket.
Verified in QA
Text field markup for outlined and elevated is different, having global style option may require change in markup and not just class. See following:
Filled: https://material.io/components/text-fields/web#filled-text
Outlined: https://material.io/components/text-fields/web#outlined-text
Issue by jauyong Monday Dec 07, 2020 at 14:24 GMT Originally opened as https://github.com/xwp/material-design-wp-plugin/issues/462
Feature description
Add options in the Customizer for global settings for text field (outlined and filled)
This ticket was split from #362 Note: there was a similar discussion regarding round corners. Question: What about theme options that cover the same settings? Note: Design may be needed here.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation brief
QA testing instructions
Demo
Changelog entry