search

material-components / material-design-for-wordpress

Material Design plugin for WordPress
78 stars 22 forks source link

Explore global settings for text fields #59

Open ravichdev opened 3 years ago

ravichdev commented 3 years ago

Issue by jauyong Monday Dec 07, 2020 at 14:24 GMT Originally opened as https://github.com/xwp/material-design-wp-plugin/issues/462

Feature description

Add options in the Customizer for global settings for text field (outlined and filled)

This ticket was split from #362 Note: there was a similar discussion regarding round corners. Question: What about theme options that cover the same settings? Note: Design may be needed here.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  1. When the Plugin and Theme are both active, "Outlined" vs "Filled" options are displayed in the Customizer's Material Design Options.
    1. This sets the block level, contact form and comment form field options.
  2. When the plugin is active but the theme is not, "Outlined" vs "Filled" options are displayed in the Customizer's Material Design Options.
    1. This sets the block level and contact form field options. (Not the comment form fields)
  3. When the theme is active but the plugin is not, "Comment field display options" will be used to set the comment form options (this is the current way)
  4. Any text field should follow the guideline set above, unless a user has specifically chosen something at the block level.
  5. Add toggle for text fields: Outlined or filled (should be called "Elevated" mocks were not updated")

image

Implementation brief

QA testing instructions

Demo

Changelog entry

ravichdev commented 3 years ago

Comment by jwold Thursday Jan 14, 2021 at 19:20 GMT

@rodydavis we're wanting to add a setting into Customizer for users to set all text fields as outlined or filled.

There are three scenarios we have to account for.

  1. Material plugin only activated
  2. Material theme
  3. Material theme and plugin activated

We'd need to have the settings in the appropriate place depending on the scenarios. What do you think?

This also applies to #463.

cc @ravichdev

ravichdev commented 3 years ago

Comment by rodydavis Friday Jan 15, 2021 at 16:07 GMT

Don't we already do this for post comments in the Customizer?

ravichdev commented 3 years ago

Comment by jwold Friday Jan 15, 2021 at 21:36 GMT

Correct, that option is already available:

Markup 2021-01-15 at 13 35 36 (1)

Was thinking something more global. cc @ravichdev whether that could make sense logically.

ravichdev commented 3 years ago

Comment by jauyong Thursday Jan 21, 2021 at 15:43 GMT

Updated the AC, need to review with team.

ravichdev commented 3 years ago

Comment by jauyong Friday Feb 12, 2021 at 16:26 GMT

Ready to be worked on by an engineer

ravichdev commented 3 years ago

Comment by jauyong Friday Feb 12, 2021 at 16:29 GMT

@dawidmlynarz to consider where to put the fill vs outline option in the customizer, when you don't have the theme.

image

ravichdev commented 3 years ago

Comment by dawidmlynarz Wednesday Feb 17, 2021 at 10:42 GMT

@jauyong Th solution proposed in #463 applies to this task as well. We can discuss it further in this ticket.

csossi commented 3 years ago

Verified in QA

PatelUtkarsh commented 3 years ago

Text field markup for outlined and elevated is different, having global style option may require change in markup and not just class. See following:

Filled: https://material.io/components/text-fields/web#filled-text

Outlined: https://material.io/components/text-fields/web#outlined-text